AA V7 by ylv-io · Pull Request #207 · KintoXYZ/kinto-core

ylv-io · 2024-06-20T17:35:53Z

Description

Type of change

Checklist:

The diff is legible and has no extraneous changes
Complex code has been commented, including external interfaces
Tests have 100% code coverage
The base branch is either main, or there's a description of how to merge

Issue Resolution

…ackedUserOperation across multiple files.

openzeppelin-code · 2024-06-20T17:41:17Z

AA V7

Generated at commit: 35b3f095670c885e224242b3bc975f1178041200

🚨 Report Summary

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	4 2 0 11 39 56
Dependencies	Critical High Medium Low Note Total	0 0 0 0 0 0

For more details view the full report in OpenZeppelin Code Inspector

…on handling to use PackedUserOperation, remove deprecated scripts, and improve gas limit packing logic.

…on and yarn.lock to clean up unused packages.

…olete JSON test data, and enhance test assertions in KintoInflator and SponsorPaymaster contracts.

…peration in EngenBadgesTest for consistency and correctness.

…e, fees, and transaction details.

github-actions · 2025-01-07T17:35:58Z

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary

encode-packed-collision (1 results) (High)
unchecked-transfer (1 results) (High)

encode-packed-collision

Impact: High
Confidence: High

ID-0
KintoInflator.compress(PackedUserOperation) calls abi.encodePacked() with multiple dynamic arguments:
- buffer = abi.encodePacked(buffer,op.paymasterAndData)

kinto-core/src/inflators/KintoInflator.sol

Lines 145 to 187 in 02f8266

    
           function compress(PackedUserOperation calldata op) external view returns (bytes memory compressed) { 
        
               // decode `callData` (selector, target, value, bytesOp) 
        
               bytes4 selector = bytes4(_slice(op.callData, 0, 4)); 
        
               bytes memory callData = _slice(op.callData, 4, op.callData.length - 4); 
        
               // set flags based on conditions 
        
               uint8 flags = _flags(selector, op, callData); 
        
               bytes memory buffer = abi.encodePacked(flags); 
        
               // encode `sender`, `nonce` and `initCode` 
        
               buffer = abi.encodePacked(buffer, op.sender, uint32(op.nonce), uint32(op.initCode.length), op.initCode); 
        
               console2.logBytes(buffer); 
        
               // encode `callData` depending on the selector 
        
               if (selector == IKintoWallet.execute.selector) { 
        
                   // if selector is `execute`, encode the callData as a single operation 
        
                   (address target, uint256 value, bytes memory bytesOp) = abi.decode(callData, (address, uint256, bytes)); 
        
                   buffer = _encodeExecuteCalldata(op, target, value, bytesOp, buffer); 
        
               } else { 
        
                   // if selector is `executeBatch`, encode the callData as a batch of operations 
        
                   (address[] memory targets, uint256[] memory values, bytes[] memory bytesOps) = 
        
                       abi.decode(callData, (address[], uint256[], bytes[])); 
        
                   buffer = _encodeExecuteBatchCalldata(targets, values, bytesOps, buffer); 
        
               } 
        
               // encode gas params 
        
               buffer = abi.encodePacked(buffer, op.accountGasLimits, op.gasFees, uint32(op.preVerificationGas)); 
        
               console2.logBytes(buffer); 
        
               // if there is a paymaster, then encode it's gas settings 
        
               if (flags & 0x02 == 0x02) { 
        
                   buffer = abi.encodePacked(buffer, op.paymasterAndData[20:52]); 
        
               } 
        
               console2.log("op.signature.length:", op.signature.length); 
        
               console2.logBytes(op.signature); 
        
               // encode `signature` content 
        
               buffer = abi.encodePacked(buffer, uint32(op.signature.length), op.signature); 
        
               console2.logBytes(buffer); 
        
               return LibZip.flzCompress(buffer); 
        
           }

unchecked-transfer

Impact: High
Confidence: Medium

ID-1
AaveWithdrawWorkflow.withdraw(address,uint256) ignores return value by IERC20(asset).transfer(safe,fee)

kinto-core/src/access/workflows/AaveWithdrawWorkflow.sol

Lines 50 to 64 in 02f8266

    
           function withdraw(address asset, uint256 amount) public returns (uint256) { 
        
               address pool = poolAddressProvider.getPool(); 
        
               // If amount is max uint256, withdraw all available 
        
               if (amount == type(uint256).max) { 
        
                   amount = IERC20(IAavePool(pool).getReserveData(asset).aTokenAddress).balanceOf(address(this)); 
        
               } 
        
               // Withdraw from Aave 
        
               IAavePool(pool).withdraw(asset, amount, address(this)); 
        
               // Send the fee to the Safe 
        
               uint256 fee = amount * FEE / 1e18; 
        
               IERC20(asset).transfer(safe, fee); 
        
               return amount - fee; 
        
           }

codecov · 2025-01-07T17:37:19Z

Codecov Report

Attention: Patch coverage is 97.77778% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.70%. Comparing base (bd848da) to head (3af76f4).

Files with missing lines	Patch %	Lines
src/paymasters/SponsorPaymaster.sol	94.44%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
+ Coverage   88.65%   88.70%   +0.05%     
==========================================
  Files          41       41              
  Lines        2521     2533      +12     
==========================================
+ Hits         2235     2247      +12     
  Misses        286      286

Files with missing lines	Coverage Δ
src/access/AccessPoint.sol	`66.66% <ø> (ø)`
src/access/AccessRegistry.sol	`93.02% <ø> (ø)`
src/inflators/KintoInflator.sol	`85.79% <100.00%> (+0.58%)`	⬆️
src/wallet/KintoWallet.sol	`94.50% <100.00%> (ø)`
src/paymasters/SponsorPaymaster.sol	`91.60% <94.44%> (+0.33%)`	⬆️

…version and optimizer settings in foundry.toml, and add KintoCounterScript for executing user operations.

Refactor import statements to use aliasing and update references to P…

b467593

…ackedUserOperation across multiple files.

ylv-io added 7 commits December 18, 2024 14:57

Merge remote-tracking branch 'origin' into feat/aa-v7

4344a5d

Refactor codebase to replace '@aa-v7' with '@aa', update user operati…

7d1ab5d

…on handling to use PackedUserOperation, remove deprecated scripts, and improve gas limit packing logic.

Remove 'account-abstraction' and related dependencies from package.js…

b350952

…on and yarn.lock to clean up unused packages.

Add logging for debugging, update paymaster data handling, remove obs…

1294f44

…olete JSON test data, and enhance test assertions in KintoInflator and SponsorPaymaster contracts.

Merge remote-tracking branch 'origin' into feat/aa-v7

4a3846b

Fix import path for Constants and update UserOperation to PackedUserO…

b981eac

…peration in EngenBadgesTest for consistency and correctness.

Add swap transaction data for WETH to USDM on Arbitrum including rout…

3af76f4

…e, fees, and transaction details.

ylv-io added 2 commits January 24, 2025 14:20

Refactor imports to use IEntryPoint from interfaces, update Solidity …

af349e2

…version and optimizer settings in foundry.toml, and add KintoCounterScript for executing user operations.

Merge remote-tracking branch 'origin' into feat/aa-v7

35b3f09

rrecuero closed this Sep 30, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AA V7#207

AA V7#207
ylv-io wants to merge 10 commits intomainfrom
feat/aa-v7

ylv-io commented Jun 20, 2024 •

edited

Loading

Uh oh!

openzeppelin-code bot commented Jun 20, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Jan 7, 2025

Uh oh!

codecov bot commented Jan 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ylv-io commented Jun 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Checklist:

Issue Resolution

Uh oh!

openzeppelin-code bot commented Jun 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

AA V7

🚨 Report Summary

Uh oh!

github-actions bot commented Jan 7, 2025

Slither report

encode-packed-collision

unchecked-transfer

Uh oh!

codecov bot commented Jan 7, 2025

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ylv-io commented Jun 20, 2024 •

edited

Loading

openzeppelin-code bot commented Jun 20, 2024 •

edited

Loading